Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.653.0 #7485

Merged
merged 13 commits into from
Aug 6, 2024
Merged

chore: release v1.653.0 #7485

merged 13 commits into from
Aug 6, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Aug 5, 2024

fix: new iconpair ui bugs and portals assets names improvements (#7491)
fix: show first icon in opportunity cards (#7488)
fix: custom asset imports regression (#7490)
feat: add code to handle multiple pairs (#7476)
feat: better portals assets display (#7473)
fix: use txid for tx link (#7484)
feat: turn portals flag on (#7471)
feat: temporary remove underlying assets for runepool (#7480)
feat: disable withdraw if runepool opportunity is not mature (#7472)
chore: prevent future myzod break parsing snapshot (#7474)
feat: implement runepool withdraw (#7449)
fix: prioritize portals market data for lp assets (#7451)
fix: make zapper akschually great again (#7470)

@gomesalexandre
Copy link
Contributor Author

Smoke test

XHRs

  • Seeing 403s on Covalent
image

Savers Withdraw

https://viewblock.io/thorchain/tx/638e6b9eef283785083a4b47add009355df3c21f6c9ad46abbbf4d42e9e22c8c

  • Miner Fees are initially 0 while loading, we should add a proper loading state there

https://jam.dev/c/9060c57b-5290-49a1-ac5c-8347fed42887

Savers Deposits

https://jam.dev/c/7f7d414d-9d2e-4ddc-a9b5-19eed8fabe59

  • On the flip side, we do have a loading state here, although refresh on confirm click is no bueno and should probably be locked

Li.Fi Multi-Hop (Hyphen)

Fees estimation failing on insufficient funds for intrinsic transaction cost

https://jam.dev/c/257001b3-15d1-4e84-886b-adcf1a11a1e6

Also tested with AllBridge:

https://jam.dev/c/52c98e07-caf8-48ae-9085-bc88ac9e0faf

And CCTP:

https://jam.dev/c/e91b80f5-95fb-4fce-9ca4-095cd34c524b

This seems to be caused by wrong balances detection on Arb One

image

Same-chain swap (0x)

https://jam.dev/c/606740e2-219a-4a39-9055-376cdcd7d4c3

@gomesalexandre gomesalexandre merged commit a5761c1 into main Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants